lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 059/257] pstore/platform: fix potential mem leak if pstore_init_fs failed
    Date
    From: chenqiwu <chenqiwu@xiaomi.com>

    [ Upstream commit 8a57d6d4ddfa41c49014e20493152c41a38fcbf8 ]

    There is a potential mem leak when pstore_init_fs failed,
    since the pstore compression maybe unlikey to initialized
    successfully. We must clean up the allocation once this
    unlikey issue happens.

    Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
    Link: https://lore.kernel.org/r/1581068800-13817-1-git-send-email-qiwuchen55@gmail.com
    Signed-off-by: Kees Cook <keescook@chromium.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/pstore/platform.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
    index d896457e7c117..408277ee3cdb9 100644
    --- a/fs/pstore/platform.c
    +++ b/fs/pstore/platform.c
    @@ -823,9 +823,9 @@ static int __init pstore_init(void)

    ret = pstore_init_fs();
    if (ret)
    - return ret;
    + free_buf_for_compression();

    - return 0;
    + return ret;
    }
    late_initcall(pstore_init);

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-04-16 17:48    [W:2.916 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site