Messages in this thread | | | Subject | Re: [PATCH v4,3/4] powerpc: sysdev: fix compile warning for fsl_85xx_cache_sram | From | Christophe Leroy <> | Date | Thu, 16 Apr 2020 17:46:49 +0200 |
| |
Le 16/04/2020 à 17:35, Wang Wenhu a écrit : > Function instantiate_cache_sram should not be linked into the init > section for its caller mpc85xx_l2ctlr_of_probe is none-__init. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Christophe Leroy <christophe.leroy@c-s.fr> > Cc: Scott Wood <oss@buserror.net> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: linuxppc-dev@lists.ozlabs.org > Fixes: 6db92cc9d07d ("powerpc/85xx: add cache-sram support") > Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > Warning information: > MODPOST vmlinux.o > WARNING: modpost: vmlinux.o(.text+0x1e540): Section mismatch in reference from the function mpc85xx_l2ctlr_of_probe() to the function .init.text:instantiate_cache_sram() > The function mpc85xx_l2ctlr_of_probe() references > the function __init instantiate_cache_sram(). > This is often because mpc85xx_l2ctlr_of_probe lacks a __init > annotation or the annotation of instantiate_cache_sram is wrong. > --- > Changes since v1: > * None > Changes since v2: > * None > Changes since v3: > * None > --- > arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c > index be3aef4229d7..3de5ac8382c0 100644 > --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c > +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c > @@ -68,7 +68,7 @@ void mpc85xx_cache_sram_free(void *ptr) > } > EXPORT_SYMBOL(mpc85xx_cache_sram_free); > > -int __init instantiate_cache_sram(struct platform_device *dev, > +int instantiate_cache_sram(struct platform_device *dev, > struct sram_parameters sram_params) > { > int ret = 0; >
| |