lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 206/257] vfio: platform: Switch to platform_get_irq_optional()
    Date
    From: Eric Auger <eric.auger@redhat.com>

    commit 723fe298ad85ad1278bd2312469ad14738953cc6 upstream.

    Since commit 7723f4c5ecdb ("driver core: platform: Add an error
    message to platform_get_irq*()"), platform_get_irq() calls dev_err()
    on an error. As we enumerate all interrupts until platform_get_irq()
    fails, we now systematically get a message such as:
    "vfio-platform fff51000.ethernet: IRQ index 3 not found" which is
    a false positive.

    Let's use platform_get_irq_optional() instead.

    Signed-off-by: Eric Auger <eric.auger@redhat.com>
    Cc: stable@vger.kernel.org # v5.3+
    Reviewed-by: Andre Przywara <andre.przywara@arm.com>
    Tested-by: Andre Przywara <andre.przywara@arm.com>
    Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/vfio/platform/vfio_platform.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/vfio/platform/vfio_platform.c
    +++ b/drivers/vfio/platform/vfio_platform.c
    @@ -44,7 +44,7 @@ static int get_platform_irq(struct vfio_
    {
    struct platform_device *pdev = (struct platform_device *) vdev->opaque;

    - return platform_get_irq(pdev, i);
    + return platform_get_irq_optional(pdev, i);
    }

    static int vfio_platform_probe(struct platform_device *pdev)

    \
     
     \ /
      Last update: 2020-04-16 17:34    [W:2.050 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site