Messages in this thread | | | Subject | Re: [PATCH v2] net/mlx5: add the missing space character | From | Hu Haowen <> | Date | Thu, 16 Apr 2020 22:44:17 +0800 |
| |
On 2020/4/9 3:42 AM, Saeed Mahameed wrote: > On Fri, 2020-04-03 at 12:26 +0800, Hu Haowen wrote: >> Commit 91b56d8462a9 ("net/mlx5: improve some comments") did not add >> that missing space character and this commit is used to fix it up. >> >> Fixes: 91b56d8462a9 ("net/mlx5: improve some comments") >> > Please re-spin and submit to net-next once net-next re-opens, > avoid referencing the above commit since this patch is a stand alone > and has nothing to do with that patch.. just have a stand alone commit > message explaining the space fix.
Sorry for my late reply. Because I'm a kernel newbie, I know nothing about the basic methods and manners in the kernel development. Thanks a lot for your patience on my mistake, pointing it out and fixing it up.
Btw, did net-next re-open and did my changes get into the mainline?
> > i fixed the commit message of the previous patch, so the Fixes tag is > unnecessary > >> Signed-off-by: Hu Haowen <xianfengting221@163.com> > >> --- >> drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c >> b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c >> index c9c9b479bda5..31bddb48e5c3 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c >> @@ -676,7 +676,7 @@ static void mlx5_fw_tracer_handle_traces(struct >> work_struct *work) >> block_count = tracer->buff.size / TRACER_BLOCK_SIZE_BYTE; >> start_offset = tracer->buff.consumer_index * >> TRACER_BLOCK_SIZE_BYTE; >> >> - /* Copy the block to local buffer to avoid HW override while >> being processed*/ >> + /* Copy the block to local buffer to avoid HW override while >> being processed */ >> memcpy(tmp_trace_block, tracer->buff.log_buf + start_offset, >> TRACER_BLOCK_SIZE_BYTE); >>
| |