Messages in this thread | | | From | "Namjae Jeon" <> | Subject | RE: [PATCH] exfat: remove the assignment of 0 to bool variable | Date | Thu, 16 Apr 2020 15:34:33 +0900 |
| |
> There is no need to init 'sync' in exfat_set_vol_flags(). > This also fixes the following coccicheck warning: > > fs/exfat/super.c:104:6-10: WARNING: Assignment of 0/1 to bool variable > > Signed-off-by: Jason Yan <yanaijie@huawei.com> Pushed it to exfat dev.
Thanks for your patch! > --- > fs/exfat/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/exfat/super.c b/fs/exfat/super.c index > 16ed202ef527..b86755468904 100644 > --- a/fs/exfat/super.c > +++ b/fs/exfat/super.c > @@ -101,7 +101,7 @@ int exfat_set_vol_flags(struct super_block *sb, > unsigned short new_flag) { > struct exfat_sb_info *sbi = EXFAT_SB(sb); > struct pbr64 *bpb; > - bool sync = 0; > + bool sync; > > /* flags are not changed */ > if (sbi->vol_flag == new_flag) > -- > 2.21.1
| |