lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 123/254] ath9k: Handle txpower changes even when TPC is disabled
    Date
    From: Remi Pommarel <repk@triplefau.lt>

    commit 968ae2caad0782db5dbbabb560d3cdefd2945d38 upstream.

    When TPC is disabled IEEE80211_CONF_CHANGE_POWER event can be handled to
    reconfigure HW's maximum txpower.

    This fixes 0dBm txpower setting when user attaches to an interface for
    the first time with the following scenario:

    ieee80211_do_open()
    ath9k_add_interface()
    ath9k_set_txpower() /* Set TX power with not yet initialized
    sc->hw->conf.power_level */

    ieee80211_hw_config() /* Iniatilize sc->hw->conf.power_level and
    raise IEEE80211_CONF_CHANGE_POWER */

    ath9k_config() /* IEEE80211_CONF_CHANGE_POWER is ignored */

    This issue can be reproduced with the following:

    $ modprobe -r ath9k
    $ modprobe ath9k
    $ wpa_supplicant -i wlan0 -c /tmp/wpa.conf &
    $ iw dev /* Here TX power is either 0 or 3 depending on RF chain */
    $ killall wpa_supplicant
    $ iw dev /* TX power goes back to calibrated value and subsequent
    calls will be fine */

    Fixes: 283dd11994cde ("ath9k: add per-vif TX power capability")
    Cc: stable@vger.kernel.org
    Signed-off-by: Remi Pommarel <repk@triplefau.lt>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/ath/ath9k/main.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/net/wireless/ath/ath9k/main.c
    +++ b/drivers/net/wireless/ath/ath9k/main.c
    @@ -1457,6 +1457,9 @@ static int ath9k_config(struct ieee80211
    ath_chanctx_set_channel(sc, ctx, &hw->conf.chandef);
    }

    + if (changed & IEEE80211_CONF_CHANGE_POWER)
    + ath9k_set_txpower(sc, NULL);
    +
    mutex_unlock(&sc->mutex);
    ath9k_ps_restore(sc);


    \
     
     \ /
      Last update: 2020-04-16 16:24    [W:5.541 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site