lkml.org 
[lkml]   [2020]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.5 073/106] leds: core: Fix warning message when init_data
    Date
    From: Ricardo Ribalda Delgado <ribalda@kernel.org>

    [ Upstream commit 64ed6588c2ea618d3f9ca9d8b365ae4c19f76225 ]

    The warning message when a led is renamed due to name collition can fail
    to show proper original name if init_data is used. Eg:

    [ 9.073996] leds-gpio a0040000.leds_0: Led (null) renamed to red_led_1 due to name collision

    Fixes: bb4e9af0348d ("leds: core: Add support for composing LED class device names")
    Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
    Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
    Signed-off-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/leds/led-class.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
    index 438774315e6c4..183de3cf6ef68 100644
    --- a/drivers/leds/led-class.c
    +++ b/drivers/leds/led-class.c
    @@ -281,7 +281,7 @@ int led_classdev_register_ext(struct device *parent,

    if (ret)
    dev_warn(parent, "Led %s renamed to %s due to name collision",
    - led_cdev->name, dev_name(led_cdev->dev));
    + proposed_name, dev_name(led_cdev->dev));

    if (led_cdev->flags & LED_BRIGHT_HW_CHANGED) {
    ret = led_add_brightness_hw_changed(led_cdev);
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-04-15 14:42    [W:4.069 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site