Messages in this thread | | | Subject | Re: [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line | From | Alexey Kardashevskiy <> | Date | Wed, 15 Apr 2020 21:21:37 +1000 |
| |
On 15/04/2020 16:18, Christoph Hellwig wrote: > On Wed, Apr 15, 2020 at 12:26:04PM +1000, Alexey Kardashevskiy wrote: >> May be this is correct and allowed (no idea) but removing exported >> symbols at least deserves a mention in the commit log, does not it? >> >> The rest of the series is fine and works. Thanks, > > Maybe I can throw in a line, but the point is that dma_direct_* > was exported as dma_* called them inline. Now dma_* is out of line > and exported instead, which always was the actual API.
They become inline in 2/4.
And the fact they were exported leaves possibility that there is a driver somewhere relying on these symbols or distro kernel won't build because the symbol disappeared from exports (I do not know what KABI guarantees or if mainline kernel cares). I do not care in particular but some might, a line separated with empty lines in the commit log would do.
-- Alexey
| |