Messages in this thread | | | Date | Wed, 15 Apr 2020 12:42:23 +0200 | From | Jan Kara <> | Subject | Re: [PATCH v2] dax: Add missing annotation for wait_entry_unlocked() |
| |
On Wed 01-04-20 16:33:59, Jules Irenge wrote: > Sparse reports a warning at wait_entry_unlocked() > > warning: context imbalance in wait_entry_unlocked() - unexpected unlock > > The root cause is the missing annotation at wait_entry_unlocked() > Add the missing __releases(xas->xa->xa_lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
The patch looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> --- > fs/dax.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/dax.c b/fs/dax.c > index 35da144375a0..ee0468af4d81 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -244,6 +244,7 @@ static void *get_unlocked_entry(struct xa_state *xas, unsigned int order) > * After we call xas_unlock_irq(), we cannot touch xas->xa. > */ > static void wait_entry_unlocked(struct xa_state *xas, void *entry) > + __releases(xas->xa->xa_lock) > { > struct wait_exceptional_entry_queue ewait; > wait_queue_head_t *wq; > -- > Change since v2 > - gives more accurate lock variable name > 2.25.1 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |