Messages in this thread | | | Subject | Re: [PATCH] power: supply: axp288_charger: Omit superfluous error message | From | Hans de Goede <> | Date | Wed, 15 Apr 2020 10:07:03 +0200 |
| |
Hi,
On 4/15/20 6:27 AM, Tang Bin wrote: > In the axp288_charger_probe(), when get irq failed, the function > platform_get_irq() logs an error message, so remove redundant > message here. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Thank you for this nice cleanup patch:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > drivers/power/supply/axp288_charger.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c > index 1bbba6bba..16fb4ae1c 100644 > --- a/drivers/power/supply/axp288_charger.c > +++ b/drivers/power/supply/axp288_charger.c > @@ -825,10 +825,9 @@ static int axp288_charger_probe(struct platform_device *pdev) > /* Register charger interrupts */ > for (i = 0; i < CHRG_INTR_END; i++) { > pirq = platform_get_irq(info->pdev, i); > - if (pirq < 0) { > - dev_err(&pdev->dev, "Failed to get IRQ: %d\n", pirq); > + if (pirq < 0) > return pirq; > - } > + > info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq); > if (info->irq[i] < 0) { > dev_warn(&info->pdev->dev, >
| |