Messages in this thread | | | Date | Wed, 15 Apr 2020 08:17:54 -0600 | From | Lina Iyer <> | Subject | Re: [PATCH] soc: qcom: cmd-db: Add debugfs dumping file |
| |
On Tue, Apr 14 2020 at 00:30 -0600, Stephen Boyd wrote: >Quoting Lina Iyer (2020-04-14 14:50:15) >> On Mon, Mar 09 2020 at 12:57 -0600, Stephen Boyd wrote: >> >+ seq_puts(seq, "-------------------------\n"); >> >+ >> >+ ent = rsc_to_entry_header(rsc); >> >+ for (j = 0; j < le16_to_cpu(rsc->cnt); j++, ent++) { >> >+ seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr), >> 0x%05x is what we would have for a resource address. > >Sorry I totally missed this because the mail wasn't trimmed at all and >it was really hard to find the one line that wasn't quoted! > Sorry, my bad. Somehow didn't notice the quoting has changed.
>5 vs. 8 sounds OK to me. Send a patch? Or I can do it if you prefer. Apart from the nit, I think the patch looks good. Feel free to add -
Reviewed-by: Lina Iyer <ilina@codeaurora.org> Tested-by: Lina Iyer <ilina@codeaurora.org>
| |