Messages in this thread | | | Date | Tue, 14 Apr 2020 17:42:50 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH][next] drivers: hv: remove redundant assignment to pointer primary_channel |
| |
On Tue, 14 Apr 2020, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com> > > The pointer primary_channel is being assigned with a value that is never,
never -> never used :)
> The assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/hv/channel_mgmt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c > index ffd7fffa5f83..f7bbb8dc4b0f 100644 > --- a/drivers/hv/channel_mgmt.c > +++ b/drivers/hv/channel_mgmt.c > @@ -425,8 +425,6 @@ void hv_process_channel_removal(struct vmbus_channel *channel) > > if (channel->primary_channel == NULL) { > list_del(&channel->listentry); > - > - primary_channel = channel; > } else { > primary_channel = channel->primary_channel; > spin_lock_irqsave(&primary_channel->lock, flags); > -- > 2.25.1 > >
| |