lkml.org 
[lkml]   [2020]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[V3 1/3] ARM64:fixed dump_backtrace() when task running on another cpu
Date
We cannot get FP and PC when the task is running on another CPU,
task->thread.cpu_context is the last time the task was switched out,
it's better to give a reminder than to provide wrong information
for example when Task blocked in spinlock/interrupt/busy loop.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
arch/arm64/kernel/traps.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
index cf402be..c74090b 100644
--- a/arch/arm64/kernel/traps.c
+++ b/arch/arm64/kernel/traps.c
@@ -106,6 +106,13 @@ void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk)
start_backtrace(&frame,
(unsigned long)__builtin_frame_address(0),
(unsigned long)dump_backtrace);
+ } else if (task_running(tsk)) {
+ /*
+ * The task is running in another cpu, we cannot get it.
+ */
+ pr_warn("tsk: %s is running in CPU%d, Don't call trace!\n",
+ tsk->comm, task_cpu(tsk));
+ return;
} else {
/*
* task blocked in __switch_to
--
2.7.4
\
 
 \ /
  Last update: 2020-04-14 14:37    [W:0.038 / U:1.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site