lkml.org 
[lkml]   [2020]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] remoteproc: Fix a bug in rproc_alloc()
From
Date
On 4/14/20 3:24 AM, Markus Elfring wrote:
>> I'm not actually sure this case causes an observable problem, but
>> it's incorrect. Fix this by initializing the notifyids field before
>> calling ida_simple_get() in rproc_alloc().
>
> I suggest to improve the commit message.
>
> * Can the information “field initialisation” be more helpful than “bug”
> in the patch subject?

No objection, though I personally would have spelled it
differently :)

> * Will the tag “Fixes” become relevant?

This bug was present when this code was first added.
Fixes: b5ab5e24e960 ("remoteproc: maintain a generic child device for each rproc")

Mathiew, feel free to add that.

-Alex


> Regards,
> Markus
>

\
 
 \ /
  Last update: 2020-04-14 14:28    [W:0.087 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site