Messages in this thread | | | Subject | Re: [PATCH 1/4] remoteproc: Fix a bug in rproc_alloc() | From | Alex Elder <> | Date | Tue, 14 Apr 2020 07:27:14 -0500 |
| |
On 4/14/20 3:24 AM, Markus Elfring wrote: >> I'm not actually sure this case causes an observable problem, but >> it's incorrect. Fix this by initializing the notifyids field before >> calling ida_simple_get() in rproc_alloc(). > > I suggest to improve the commit message. > > * Can the information “field initialisation” be more helpful than “bug” > in the patch subject?
No objection, though I personally would have spelled it differently :)
> * Will the tag “Fixes” become relevant?
This bug was present when this code was first added. Fixes: b5ab5e24e960 ("remoteproc: maintain a generic child device for each rproc")
Mathiew, feel free to add that.
-Alex
> Regards, > Markus >
| |