Messages in this thread | | | Subject | Re: [PATCH v6 2/3] powerpc/powernv: Introduce support and parsing for self-save API | From | Pratik Sampat <> | Date | Tue, 14 Apr 2020 17:48:31 +0530 |
| |
Hello Gautham,
[..snip..]
>> + >> + if (curr_spr.supported_mode & FIRMWARE_SELF_SAVE) { >> + rc = opal_slw_self_save_reg(pir, >> + curr_spr.spr); >> + if (rc != 0) >> + return rc; >> + switch (curr_spr.spr) { >> + case SPRN_LPCR: >> + is_lpcr_self_save = true; > Could you consider converting is_lpcr_self_save and is_ptcr_self_save > into static_keys ? For reference see commit > 14c73bd344da("powerpc/vcpu: Assume dedicated processors as > non-preempt") > Sure, using static keys is cleaner.
I'll also address the other nits mentioned in the e-mail earlier.
Thanks for the review. Pratik
| |