Messages in this thread | | | Date | Tue, 14 Apr 2020 12:05:55 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 1/2] [V2 1/2]sched:add task_running_oncpu |
| |
On Tue, Apr 14, 2020 at 09:20:57AM +0200, Vincent Guittot wrote: > On Mon, 13 Apr 2020 at 14:04, Wang Qing <wangqing@vivo.com> wrote: > > > > We have no interface whether the task is running, > > so we need to add an interface and distinguish CONFIG_SMP. > > > > Signed-off-by: Wang Qing <wangqing@vivo.com> > > --- > > include/linux/sched.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > index 4418f5c..13cc8f5 100644 > > --- a/include/linux/sched.h > > +++ b/include/linux/sched.h > > @@ -1843,6 +1843,11 @@ static inline unsigned int task_cpu(const struct task_struct *p) > > > > extern void set_task_cpu(struct task_struct *p, unsigned int cpu); > > > > +static inline int task_running_oncpu(const struct task_struct *p) > > This function name is too close from task_running_on_cpu() and can be > misleading as the difference is only "_" > Also, how task_running_oncpu() is different from task_running() ?
It doesn't have the (arguably superfluous) rq argument. But yes, agreed, if anything lift that thing (without the argument).
| |