Messages in this thread | | | Subject | Re: [PATCH v2 0/6] arm64: add the time namespace support | From | Vincenzo Frascino <> | Date | Tue, 14 Apr 2020 10:02:53 +0100 |
| |
Hi Andrei,
On 4/11/20 8:33 AM, Andrei Vagin wrote: > On Thu, Apr 9, 2020 at 6:23 AM Vincenzo Frascino > <vincenzo.frascino@arm.com> wrote: >> >> Hi Andrei, >> [...]
>> Sorry for the delay, I completed this morning the review of your patches and I >> do not have anymore comments on them. Thank you for making the effort and >> bringing the time namespace support to arm64. > > Thank you for the review of these patches. > >> >> I have though a question on something I encountered during the testing of the >> patches: I noticed that all the tests related to CLOCK_BOOTTIME_ALARM fail on >> arm64 (please find the results below the scissors). Is this expected? > > static int alarm_clock_get_timespec(clockid_t which_clock, struct > timespec64 *tp) > { > struct alarm_base *base = &alarm_bases[clock2alarm(which_clock)]; > > if (!alarmtimer_get_rtcdev()) > return -EINVAL; > > It is probably that you get EINVAL from here ^^^. I will send a > separate patch to handle this case in tests properly. >
This makes sense :) Please let me know when you post the fix so I can test it again.
Are you planning as well to rebase this set?
> Thanks, > Andrei >
-- Regards, Vincenzo
| |