lkml.org 
[lkml]   [2020]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 03/11] arch_topology: Make it avilable for MIPS
    On Sun, Apr 12, 2020 at 11:20:33AM +0800, Jiaxun Yang wrote:
    > Simply drop unnecessary archtecture limitions and add dummy
    > function for platforms without OF support.
    > As some of the functions are conflicting with Arm's platform
    > implementations, we mark them as weak.
    >
    > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
    > --
    > v2: Use weak instead of ifdef to exclude functions for Arm.
    > ---
    > drivers/base/arch_topology.c | 116 ++++++++++++++++++-----------------
    > 1 file changed, 60 insertions(+), 56 deletions(-)
    >
    > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
    > index 4d0a0038b476..13dc4fbf043f 100644
    > --- a/drivers/base/arch_topology.c
    > +++ b/drivers/base/arch_topology.c
    > @@ -143,57 +143,6 @@ void topology_normalize_cpu_scale(void)
    > }
    > }
    >
    > -bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu)

    This function is not under any #ifdefery and you are adding it but the
    commit message indicates opposite. Please state the reason why this needs
    to be moved under #ifdef

    --
    Regards,
    Sudeep

    \
     
     \ /
      Last update: 2020-04-14 10:26    [W:4.293 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site