Messages in this thread Patch in this message | | | Date | Tue, 14 Apr 2020 08:20:51 -0000 | From | "tip-bot2 for Colin Ian King" <> | Subject | [tip: efi/urgent] efi/libstub/x86: Remove redundant assignment to pointer hdr |
| |
The following commit has been merged into the efi/urgent branch of tip:
Commit-ID: 05a08796281feefcbe5cfdd67b48f5073d309aa8 Gitweb: https://git.kernel.org/tip/05a08796281feefcbe5cfdd67b48f5073d309aa8 Author: Colin Ian King <colin.king@canonical.com> AuthorDate: Thu, 09 Apr 2020 15:04:27 +02:00 Committer: Ingo Molnar <mingo@kernel.org> CommitterDate: Tue, 14 Apr 2020 08:32:12 +02:00
efi/libstub/x86: Remove redundant assignment to pointer hdr
The pointer hdr is being assigned a value that is never read and it is being updated later with a new value. The assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Ard Biesheuvel <ardb@kernel.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Link: https://lore.kernel.org/r/20200402102537.503103-1-colin.king@canonical.com Link: https://lore.kernel.org/r/20200409130434.6736-3-ardb@kernel.org --- drivers/firmware/efi/libstub/x86-stub.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c index 8d3a707..e02ea51 100644 --- a/drivers/firmware/efi/libstub/x86-stub.c +++ b/drivers/firmware/efi/libstub/x86-stub.c @@ -392,8 +392,6 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle, image_base = efi_table_attr(image, image_base); image_offset = (void *)startup_32 - image_base; - hdr = &((struct boot_params *)image_base)->hdr; - status = efi_allocate_pages(0x4000, (unsigned long *)&boot_params, ULONG_MAX); if (status != EFI_SUCCESS) { efi_printk("Failed to allocate lowmem for boot params\n");
| |