Messages in this thread | | | From | Vincent Guittot <> | Date | Tue, 14 Apr 2020 10:08:58 +0200 | Subject | Re: [PATCH-next] sched/topology: use true, false for bool variable |
| |
On Mon, 13 Apr 2020 at 13:55, Zou Wei <zou_wei@huawei.com> wrote: > > Fixes coccicheck warning: > > kernel/sched/topology.c:224:3-22: WARNING: Assignment of 0/1 to bool variable > kernel/sched/topology.c:226:3-22: WARNING: Assignment of 0/1 to bool variable > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com>
You will probably be interested by this thread https://lkml.org/lkml/2020/3/27/785
> --- > kernel/sched/topology.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 8344757b..e4d6464 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -221,9 +221,9 @@ int sched_energy_aware_handler(struct ctl_table *table, int write, > state = static_branch_unlikely(&sched_energy_present); > if (state != sysctl_sched_energy_aware) { > mutex_lock(&sched_energy_mutex); > - sched_energy_update = 1; > + sched_energy_update = true; > rebuild_sched_domains(); > - sched_energy_update = 0; > + sched_energy_update = false; > mutex_unlock(&sched_energy_mutex); > } > } > -- > 2.6.2 >
| |