lkml.org 
[lkml]   [2020]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] staging: rtl8192u: Refactoring setKey function
From
Date
On Tue, 2020-04-14 at 22:18 -0300, Camylla Cantanheide wrote:
> Em ter., 14 de abr. de 2020 às 09:35, Dan Carpenter <
> dan.carpenter@oracle.com> escreveu:
[]
> > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c
[]
> > > + target_content = macaddr[0] << 16 |
> > > + macaddr[0] << 24 |
> > > + (u32)us_config;

And Camylla, this statement should be

+ target_content = macaddr[0] << 16 |
+ macaddr[1] << 24 |
+ (u32)us_config;

Not a repeated [0]

> > > +
> > > + write_nic_dword(dev, WCAMI, target_content);
> > > + write_nic_dword(dev, RWCAM, target_command++);
> > > +
> > > + /* MAC */
> > > + target_content = macaddr[2] |
> > > + macaddr[3] << 8 |
> > > + macaddr[4] << 16 |
> > > + macaddr[5] << 24;



\
 
 \ /
  Last update: 2020-04-15 05:12    [W:0.153 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site