Messages in this thread | | | Date | Wed, 15 Apr 2020 10:54:26 +0800 | From | Dejin Zheng <> | Subject | Re: [PATCH v1] i2c: img-scb: remove duplicate dev_err() |
| |
On Tue, Apr 14, 2020 at 05:48:41PM +0200, Markus Elfring wrote: > > it will print an error message by itself when platform_get_irq() > > goes wrong. so don't need dev_err() in here again. > > I suggest to improve the change description. > Can you get any further inspiration by previous patches from > other contributors according to the presented transformation pattern? > > Would you like to adjust any more source files in the mentioned > software area? > Hi Markus:
Thanks for your comments, and maybe we can use coccinelle tools for more source files do this change in the mentioned software area.
BR, Dejin > Regards, > Markus
| |