Messages in this thread | | | Subject | Re: [PATCH] ipmi:bt-bmc: Delete superfluous dev_warm() inbt_bmc_config_irq() | From | Tang Bin <> | Date | Wed, 15 Apr 2020 09:28:57 +0800 |
| |
Hi Corey:
On 2020/4/15 3:44, Corey Minyard wrote: > On Tue, Apr 14, 2020 at 10:19:51PM +0800, Tang Bin wrote: >> The priority of dev_warm() is higher than dev_info(),so if the >> function bt_bmc_probe() uses dev_info() to print error message, >> the dev_warm() is redundant.Thus should be removed. > Actually, this needs to be left in. That error is not just a that irqs > were not configured, that's an error that something else went wrong.
Oh ,It's my fault.
I had read the previous email with you again, and mistook it as that you agreed with my point of view. I feel humiliated now.
Thanks,
Tang Bin
| |