lkml.org 
[lkml]   [2020]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 40/70] x86/sev-es: Setup per-cpu GHCBs for the runtime handler
    From
    Date
    On 4/14/20 1:04 PM, Tom Lendacky wrote:
    >> set_memory_decrypted needs to check the return value. I see it
    >> consistently return ENOMEM. I've traced that back to split_large_page
    >> in arch/x86/mm/pat/set_memory.c.
    >
    > At that point the guest won't be able to communicate with the
    > hypervisor, too. Maybe we should BUG() here to terminate further
    > processing?

    Escalating an -ENOMEM into a crashed kernel seems a bit extreme.
    Granted, the guest may be in an unrecoverable state, but the host
    doesn't need to be too.

    \
     
     \ /
      Last update: 2020-04-14 22:15    [W:4.110 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site