lkml.org 
[lkml]   [2020]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [External] Re: [PATCH] mm/ksm: Fix a null pointer dereference
On Tue, Apr 14, 2020 at 3:14 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > The find_mergeable_vma can return NULL. In this case, it leads
> > to crash when we access vma->vm_mm(which's offset is 0x40) in
>
> I suggest to improve the commit message.
>
> * Wording alternative:
> to a crash when we access vma->vm_mm (its offset is 0x40) in
>
> * Can a function name be nicer than the information “at 0000000000000040”
> in the patch subject?
>
> * Would you like to add the tag “Fixes” to the change description?
>

Thanks for your suggestion. I will send a v2 patch later.


--
Yours,
Muchun

\
 
 \ /
  Last update: 2020-04-14 09:21    [W:0.034 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site