Messages in this thread | | | Date | Sun, 12 Apr 2020 23:05:50 -0700 | From | Vito Caputo <> | Subject | Re: kernel BUG at net/phonet/socket.c:LINE! |
| |
On Mon, Apr 13, 2020 at 09:01:58AM +0300, Rémi Denis-Courmont wrote: > Le maanantaina 13. huhtikuuta 2020, 8.49.14 EEST Vito Caputo a écrit : > > > If we are to distinguish the two error scenarii, then it's the rebind > > > case > > > that needs a different error, but EINVAL is consistent with INET. > > > > Isn't the existing code is bugged if treating -EINVAL as valid and a rebind? > > > > The invalid size will return a NULL sobject but -EINVAL, triggering the > > BUG_ON. > > How do you pass an invalid size? It's a constant `sizeof(struct sockaddr_pn)` > in that code path. >
duh, sorry for the noise, I should have re-read the code before replying.
| |