lkml.org 
[lkml]   [2020]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 025/108] net/mlx5e: Init ethtool steering for representors
    Date
    From: Vlad Buslov <vladbu@mellanox.com>

    [ Upstream commit 6783e8b29f636383af293a55336f036bc7ad5619 ]

    During transition to uplink representors the code responsible for
    initializing ethtool steering functionality wasn't added to representor
    init rx routine. This causes NULL pointer dereference during configuration
    of network flow classification rule with ethtool (only possible to
    reproduce with next commit in this series which registers necessary ethtool
    callbacks).

    Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
    Reviewed-by: Roi Dayan <roid@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
    index cd9bb7c7b3413..397b70fb23e23 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
    @@ -1590,6 +1590,8 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv)
    if (err)
    goto err_destroy_ttc_table;

    + mlx5e_ethtool_init_steering(priv);
    +
    return 0;

    err_destroy_ttc_table:
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-04-12 01:32    [W:2.908 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site