Messages in this thread | | | From | Ezequiel Garcia <> | Date | Sat, 11 Apr 2020 20:11:43 -0300 | Subject | Re: [PATCH] media: gspca: remove redundant assignment to variable status |
| |
On Fri, 10 Apr 2020 at 11:18, Colin King <colin.king@canonical.com> wrote: > > From: Colin Ian King <colin.king@canonical.com> > > The variable status is being assigned a value that is never read. > The assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
> --- > drivers/media/usb/gspca/mr97310a.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/usb/gspca/mr97310a.c b/drivers/media/usb/gspca/mr97310a.c > index 502fc2eaffe0..464aa61cd914 100644 > --- a/drivers/media/usb/gspca/mr97310a.c > +++ b/drivers/media/usb/gspca/mr97310a.c > @@ -287,7 +287,6 @@ static int zero_the_pointer(struct gspca_dev *gspca_dev) > return err_code; > > err_code = cam_get_response16(gspca_dev, 0x21, 0); > - status = data[0]; > tries++; > if (err_code < 0) > return err_code; > -- > 2.25.1 >
| |