Messages in this thread | | | Subject | Re: [PATCH] taging: android: ashmem: Declared const key | From | Joe Perches <> | Date | Sat, 11 Apr 2020 12:41:26 -0700 |
| |
On Sun, 2020-04-12 at 00:59 +0530, MugilRaj wrote: > From: mugil2301 <110117057@nitt.edu>
You need to verify the patch subject. You need a change log message too.
> Signed-off-by: mugil2301 <110117057@nitt.edu>
You need to put your legal name here
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c [] > @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0;
(this won't compile)
checkpatch is not always right.
Do please compile the files changed by your patch and verify change correctness before sending any proposed patch.
| |