Messages in this thread | | | Date | Sat, 11 Apr 2020 15:13:47 +0200 | From | Paul Cercueil <> | Subject | Re: [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message |
| |
Hi Christophe,
Le sam. 11 avril 2020 à 8:38, Christophe JAILLET <christophe.jaillet@wanadoo.fr> a écrit : > Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
Is that so?
From what I could see these macros add the \n themselves if needed. So the \n were omitted on purpose.
-Paul
> Fixes: 541368b46b82 ("usb: phy: Add driver for the Ingenic JZ4770 USB > transceiver") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/usb/phy/phy-jz4770.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/phy/phy-jz4770.c > b/drivers/usb/phy/phy-jz4770.c > index 3ea1f5b9bcf8..8f62dc2a90ff 100644 > --- a/drivers/usb/phy/phy-jz4770.c > +++ b/drivers/usb/phy/phy-jz4770.c > @@ -125,13 +125,13 @@ static int jz4770_phy_init(struct usb_phy *phy) > > err = regulator_enable(priv->vcc_supply); > if (err) { > - dev_err(priv->dev, "Unable to enable VCC: %d", err); > + dev_err(priv->dev, "Unable to enable VCC: %d\n", err); > return err; > } > > err = clk_prepare_enable(priv->clk); > if (err) { > - dev_err(priv->dev, "Unable to start clock: %d", err); > + dev_err(priv->dev, "Unable to start clock: %d\n", err); > return err; > } > > @@ -191,7 +191,7 @@ static int jz4770_phy_probe(struct > platform_device *pdev) > > priv->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(priv->base)) { > - dev_err(dev, "Failed to map registers"); > + dev_err(dev, "Failed to map registers\n"); > return PTR_ERR(priv->base); > } > > @@ -199,7 +199,7 @@ static int jz4770_phy_probe(struct > platform_device *pdev) > if (IS_ERR(priv->clk)) { > err = PTR_ERR(priv->clk); > if (err != -EPROBE_DEFER) > - dev_err(dev, "Failed to get clock"); > + dev_err(dev, "Failed to get clock\n"); > return err; > } > > @@ -207,14 +207,14 @@ static int jz4770_phy_probe(struct > platform_device *pdev) > if (IS_ERR(priv->vcc_supply)) { > err = PTR_ERR(priv->vcc_supply); > if (err != -EPROBE_DEFER) > - dev_err(dev, "failed to get regulator"); > + dev_err(dev, "Failed to get regulator\n"); > return err; > } > > err = usb_add_phy(&priv->phy, USB_PHY_TYPE_USB2); > if (err) { > if (err != -EPROBE_DEFER) > - dev_err(dev, "Unable to register PHY"); > + dev_err(dev, "Unable to register PHY\n"); > return err; > } > > -- > 2.20.1 >
| |