lkml.org 
[lkml]   [2020]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH/RFC] clk: gate: Add some kunit test suites
From
Date
Quoting Brendan Higgins (2020-04-09 13:09:03)
> On Tue, Apr 7, 2020 at 8:56 PM Stephen Boyd <sboyd@kernel.org> wrote:
> >
> > Test various parts of the clk gate implementation with the kunit testing
> > framework.
> >
> > Cc: Brendan Higgins <brendanhiggins@google.com>
> > Cc: <kunit-dev@googlegroups.com>
> > Signed-off-by: Stephen Boyd <sboyd@kernel.org>
>
> One very minor nit below, other than that this looks great! I couldn't
> have done a better job myself.
>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
>
> > ---
> >
> > This patch is on top of this series[1] that allows the clk
> > framework to be selected by Kconfig language.
> >
> > [1] https://lore.kernel.org/r/20200405025123.154688-1-sboyd@kernel.org
> >
> > drivers/clk/Kconfig | 8 +
> > drivers/clk/Makefile | 1 +
> > drivers/clk/clk-gate-test.c | 481 ++++++++++++++++++++++++++++++++++++
> > 3 files changed, 490 insertions(+)
> > create mode 100644 drivers/clk/clk-gate-test.c
> >
> > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> > index 6ea0631e3956..66193673bcdf 100644
> > --- a/drivers/clk/Kconfig
> > +++ b/drivers/clk/Kconfig
> > @@ -377,4 +377,12 @@ source "drivers/clk/ti/Kconfig"
> > source "drivers/clk/uniphier/Kconfig"
> > source "drivers/clk/zynqmp/Kconfig"
> >
> > +# Kunit test cases
>
> Minor nit: Elsewhere you use KUnit.
>
> I wasn't going to say anything because so many people go with the
> "Kunit" capitalization (and actually I kind of prefer it), but you
> should at least be consistent within your patch.

Ok I will go with Kunit. Thanks!

\
 
 \ /
  Last update: 2020-04-11 04:10    [W:0.090 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site