Messages in this thread | | | From | Michael Kelley <> | Subject | RE: [PATCH 04/11] hv_netvsc: Disable NAPI before closing the VMBus channel | Date | Fri, 10 Apr 2020 19:20:16 +0000 |
| |
From: Andrea Parri (Microsoft) <parri.andrea@gmail.com> Sent: Sunday, April 5, 2020 5:15 PM > > vmbus_chan_sched() might call the netvsc driver callback function that > ends up scheduling NAPI work. This "work" can access the channel ring > buffer, so we must ensure that any such work is completed and that the > ring buffer is no longer being accessed before freeing the ring buffer > data structure in the channel closure path. To this end, disable NAPI > before calling vmbus_close() in netvsc_device_remove(). > > Suggested-by: Michael Kelley <mikelley@microsoft.com> > Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com> > Acked-by: Stephen Hemminger <stephen@networkplumber.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: <netdev@vger.kernel.org> > --- > drivers/hv/channel.c | 6 ++++++ > drivers/net/hyperv/netvsc.c | 7 +++++-- > 2 files changed, 11 insertions(+), 2 deletions(-) >
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
| |