lkml.org 
[lkml]   [2020]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 19/19] staging: wfx: drop useless update of macaddr
Date
From: Jérôme Pouiller <jerome.pouiller@silabs.com>

Mac address is set in wfx_add_interface() and removed in
wfx_remove_interface().

Currently, there is also an additional update of mac address in
wfx_do_unjoin(). It has no rationale. Mac address is already present
and nothing has changed it. Therefore, we can drop it.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
---
drivers/staging/wfx/sta.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index 53ab9648184a..f1df7717d5f4 100644
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -415,7 +415,6 @@ static void wfx_do_unjoin(struct wfx_vif *wvif)
wfx_tx_lock_flush(wvif->wdev);
hif_reset(wvif, false);
wfx_tx_policy_init(wvif);
- hif_set_macaddr(wvif, wvif->vif->addr);
if (wvif_count(wvif->wdev) <= 1)
hif_set_block_ack_policy(wvif, 0xFF, 0xFF);
wfx_free_event_queue(wvif);
--
2.25.1
\
 
 \ /
  Last update: 2020-04-10 15:34    [W:0.125 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site