Messages in this thread | | | Date | Fri, 10 Apr 2020 10:45:16 +0200 | From | Willy Tarreau <> | Subject | Re: [PATCH 22/23] floppy: cleanup: do not iterate on current_fdc in DMA grab/release functions |
| |
On Fri, Apr 10, 2020 at 11:35:51AM +0300, Denis Efremov wrote: > I see a couple of similar cycles in do_floppy_init: > > for (i = 0; i < N_FDC; i++) { > current_fdc = i; > memset(&fdc_state[current_fdc], 0, sizeof(*fdc_state)); > fdc_state[current_fdc].dtr = -1; > fdc_state[current_fdc].dor = 0x4; > ... > } > > for (i = 0; i < N_FDC; i++) { > current_fdc = i; > fdc_state[current_fdc].driver_version = FD_DRIVER_VERSION; > ... > }
Ah thanks, I missed these ones! Do you want me to respin this patch ?
Willy
| |