Messages in this thread | | | Date | Wed, 1 Apr 2020 09:39:44 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v3 1/2] hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase |
| |
On Fri, Mar 20, 2020 at 11:16:21AM -0500, Grant Peltier wrote: > Extend the isl68137 driver to provide support for 2nd generation Renesas > digital multiphase voltage regulators. > > Signed-off-by: Grant Peltier <grantpeltier93@gmail.com> > --- [ ... ]
> > -static const struct i2c_device_id isl68137_id[] = { > - {"isl68137", 0}, > +static const struct i2c_device_id raa_dmpvr_id[] = { > + {"isl68137", isl68137}, > + {"raa_dmpvr2_1rail", raa_dmpvr2_1rail}, > + {"raa_dmpvr2_2rail", raa_dmpvr2_2rail}, > + {"raa_dmpvr2_3rail", raa_dmpvr2_3rail}, > + {"raa_dmpvr2_hv", raa_dmpvr2_hv}, > {}
I clearly didn't pay attention. I2C device IDs need to match chip names, not functionality. Unfortunately I only realized that when I wrote the pull request, and I didn't want to drop the patch. I'll send a fixup patch later.
Guenter
| |