Messages in this thread | | | Date | Wed, 1 Apr 2020 09:05:40 -0700 | From | Jacob Pan <> | Subject | Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function |
| |
On Wed, 1 Apr 2020 09:32:37 +0200 Auger Eric <eric.auger@redhat.com> wrote:
> >> devtlb > >> descriptor, that is why Eric suggests {0, 0, 1}. > > > > I think it should be {0, 0, 1} :-) addr field and S field are must, > > pasid field depends on G bit. > > On my side, I understood from the spec that addr/S are always used > whatever the granularity, hence the above suggestion. > > As a comparison, for PASID based IOTLB invalidation, it is clearly > stated that if G matches PASID selective invalidation, address field > is ignored. This is not written that way for PASID-based device TLB > inv. > > I misread the S bit. It all makes sense now. Thanks for the proposal and explanation.
Jacob
| |