lkml.org 
[lkml]   [2020]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv3 1/2] sysctl/sysrq: Remove __sysrq_enabled copy
From
Date
Hi Michael,

On 4/1/20 1:22 PM, Michael Ellerman wrote:
[..]
>>
>> +/**
>> + * sysrq_mask - Getter for sysrq_enabled mask.
>> + *
>> + * Return: 1 if sysrq is always enabled, enabled sysrq_key_op mask otherwise.
>> + */
>> +int sysrq_mask(void)
>> +{
>> + if (sysrq_always_enabled)
>> + return 1;
>> + return sysrq_enabled;
>> +}
>
> This seems to have broken several configs, when serial_core is modular, with:
>
> ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
>
> See:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/14169386/
>
> It's also being reported by the kernelci bot:
>
> https://lore.kernel.org/linux-next/5e677bd0.1c69fb81.c43fe.7f7d@mx.google.com/


Thanks for reporting this,

I've reproduced it and sent a fix:
https://lkml.kernel.org/r/20200401143904.423450-1-dima@arista.com

Thanks,
Dmitry

\
 
 \ /
  Last update: 2020-04-01 16:42    [W:0.044 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site