Messages in this thread | | | Date | Wed, 1 Apr 2020 11:32:20 +0100 | From | Will Deacon <> | Subject | Re: [PATCH] checkpatch: Warn about data_race() without comment |
| |
On Wed, Apr 01, 2020 at 12:17:14PM +0200, Marco Elver wrote: > Warn about applications of data_race() without a comment, to encourage > documenting the reasoning behind why it was deemed safe. > > Suggested-by: Will Deacon <will@kernel.org> > Signed-off-by: Marco Elver <elver@google.com> > --- > scripts/checkpatch.pl | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index a63380c6b0d2..48bb9508e300 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -5833,6 +5833,14 @@ sub process { > } > } > > +# check for data_race without a comment. > + if ($line =~ /\bdata_race\s*\(/) { > + if (!ctx_has_comment($first_line, $linenr)) { > + WARN("DATA_RACE", > + "data_race without comment\n" . $herecurr); > + } > + } > +
Thanks, looks sane to me:
Acked-by: Will Deacon <will@kernel.org>
Although I suppose I now need to add some comments to my list stuff. I didn't think that through, did I? ;)
Will
| |