Messages in this thread | | | Subject | Re: [PATCH v2 6/6] Input: snvs_pwrkey - only IRQ_HANDLED for our own events | From | Horia Geantă <> | Date | Wed, 1 Apr 2020 11:58:49 +0300 |
| |
On 3/28/2020 5:43 AM, Adam Ford wrote: > On Mon, Mar 2, 2020 at 3:22 AM Horia Geanta <horia.geanta@nxp.com> wrote: >> >> On 2/25/2020 6:12 PM, André Draszik wrote: >>> The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc. >>> >>> This driver here should only return IRQ_HANDLED if the status register >>> indicates that the event we're handling in the irq handler was genuinely >>> intended for this driver. Otheriwse the interrupt subsystem will >>> assume the interrupt was handled successfully even though it wasn't >>> at all. >>> >>> Signed-off-by: André Draszik <git@andred.net> >>> Cc: "Horia Geantă" <horia.geanta@nxp.com> >>> Cc: Aymen Sghaier <aymen.sghaier@nxp.com> >>> Cc: Herbert Xu <herbert@gondor.apana.org.au> >>> Cc: "David S. Miller" <davem@davemloft.net> >>> Cc: Rob Herring <robh+dt@kernel.org> >>> Cc: Mark Rutland <mark.rutland@arm.com> >>> Cc: Shawn Guo <shawnguo@kernel.org> >>> Cc: Sascha Hauer <s.hauer@pengutronix.de> >>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> >>> Cc: Fabio Estevam <festevam@gmail.com> >>> Cc: NXP Linux Team <linux-imx@nxp.com> >>> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> >>> Cc: Anson Huang <Anson.Huang@nxp.com> >>> Cc: Robin Gong <yibin.gong@nxp.com> >>> Cc: linux-crypto@vger.kernel.org >>> Cc: devicetree@vger.kernel.org >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-input@vger.kernel.org >> For patches 2-6: >> Reviewed-by: Horia Geantă <horia.geanta@nxp.com> >> >> Also imx8mn.dtsi and imx8mp.dtsi will have to be updated. > > Is there an update coming for the 8mn family? I am seeing it not wake > from the power key, and I was hoping to resolve that before i make a > push to submit a new 8MN board for review. > Starting with linux-next next-20200320, there's commit arm64: dts: imx8mn: Add snvs clock to powerkey
Could you confirm you've tested with a tree including it?
Thanks, Horia
| |