lkml.org 
[lkml]   [2020]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 06/16] powerpc/watchpoint: Provide DAWR number to __set_breakpoint
From
Date


On 4/1/20 12:33 PM, Christophe Leroy wrote:
>
>
> Le 01/04/2020 à 08:12, Ravi Bangoria a écrit :
>> Introduce new parameter 'nr' to __set_breakpoint() which indicates
>> which DAWR should be programed. Also convert current_brk variable
>> to an array.
>>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
>> ---
>>   arch/powerpc/include/asm/debug.h         |  2 +-
>>   arch/powerpc/include/asm/hw_breakpoint.h |  2 +-
>>   arch/powerpc/kernel/hw_breakpoint.c      |  8 ++++----
>>   arch/powerpc/kernel/process.c            | 14 +++++++-------
>>   arch/powerpc/kernel/signal.c             |  2 +-
>>   arch/powerpc/xmon/xmon.c                 |  2 +-
>>   6 files changed, 15 insertions(+), 15 deletions(-)
>>
>> diff --git a/arch/powerpc/include/asm/debug.h b/arch/powerpc/include/asm/debug.h
>> index 7756026b95ca..6228935a8b64 100644
>> --- a/arch/powerpc/include/asm/debug.h
>> +++ b/arch/powerpc/include/asm/debug.h
>> @@ -45,7 +45,7 @@ static inline int debugger_break_match(struct pt_regs *regs) { return 0; }
>>   static inline int debugger_fault_handler(struct pt_regs *regs) { return 0; }
>>   #endif
>> -void __set_breakpoint(struct arch_hw_breakpoint *brk);
>> +void __set_breakpoint(struct arch_hw_breakpoint *brk, int nr);
>
> Same, I think it would make more sense to have nr as first argument.

Sorry, didn't get your point. How will that help?

Ravi

\
 
 \ /
  Last update: 2020-04-01 10:58    [W:0.037 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site