lkml.org 
[lkml]   [2020]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] tty/sysrq: Export sysrq_mask()
Date
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Wed, Apr 01, 2020 at 03:49:56PM +0100, Dmitry Safonov wrote:
>> On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote:
>> > On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
>> >> Build fix for serial_core being module:
>> >> ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
>> >>
>> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> >> Cc: Jiri Slaby <jslaby@suse.com>
>> >> Reported-by: "kernelci.org bot" <bot@kernelci.org>
>> >> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
>> >> Signed-off-by: Dmitry Safonov <dima@arista.com>
>> >> ---
>> >> drivers/tty/sysrq.c | 1 +
>> >> 1 file changed, 1 insertion(+)
>> >
>> > Is this a new problem? What commit does this fix?
>>
>> Right, sorry I've managed to forget adding the tag:
>>
>> Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")
>>
>> Maybe also:
>>
>> Link:
>> https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@mpe.ellerman.id.au/
>
> Thanks, that works. WIll queue this up after -rc1 is out.

Why wait until after rc1?

It's a build break for a bunch of folks and the fix is obviously correct
(famous last words).

cheers

\
 
 \ /
  Last update: 2020-04-02 03:45    [W:0.057 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site