Messages in this thread | | | Date | Mon, 9 Mar 2020 21:41:04 +0800 | From | Baoquan He <> | Subject | Re: [PATCH v3 6/7] mm/sparse.c: move subsection_map related codes together |
| |
On 03/09/20 at 10:08am, David Hildenbrand wrote: > On 07.03.20 09:42, Baoquan He wrote: > > No functional change. > > > > Signed-off-by: Baoquan He <bhe@redhat.com> > > --- > > mm/sparse.c | 134 +++++++++++++++++++++++++--------------------------- > > 1 file changed, 65 insertions(+), 69 deletions(-)
> > IMHO, we don't need this patch - but just my personal opinion. Change > itself looks good on a quick glance.
I personally like seeing function set operating on one data structure being put together. To me, I use vi+ctags+cscope to jump to called funtion easily. When try to get a picture of a data and handling, e.g here the subsection map and the relevant functions, putting them together is better to understand code. I am also fine to discard this patch, no patch has dependency on this one in this series, it's easy to not pick it if no one like it.
| |