lkml.org 
[lkml]   [2020]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/15] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting
    Date
    Xmon allows overwriting breakpoints because it's supported by only
    one dawr. But with multiple dawrs, overwriting becomes ambiguous
    or unnecessary complicated. So let's not allow it.

    Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
    ---
    arch/powerpc/xmon/xmon.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
    index 0ca0d29f99c6..ac18fe3e4295 100644
    --- a/arch/powerpc/xmon/xmon.c
    +++ b/arch/powerpc/xmon/xmon.c
    @@ -1381,6 +1381,10 @@ bpt_cmds(void)
    printf("Hardware data breakpoint not supported on this cpu\n");
    break;
    }
    + if (dabr.enabled) {
    + printf("Couldn't find free breakpoint register\n");
    + break;
    + }
    mode = 7;
    cmd = inchar();
    if (cmd == 'r')
    --
    2.21.1
    \
     
     \ /
      Last update: 2020-03-09 09:59    [W:2.028 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site