Messages in this thread | | | Date | Sun, 08 Mar 2020 21:29:11 -0700 (PDT) | Subject | Re: [PATCH v2] net: stmmac: dwmac1000: Disable ACS if enhanced descs are not used | From | David Miller <> |
| |
From: Remi Pommarel <repk@triplefau.lt> Date: Sun, 8 Mar 2020 10:25:56 +0100
> ACS (auto PAD/FCS stripping) removes FCS off 802.3 packets (LLC) so that > there is no need to manually strip it for such packets. The enhanced DMA > descriptors allow to flag LLC packets so that the receiving callback can > use that to strip FCS manually or not. On the other hand, normal > descriptors do not support that. > > Thus in order to not truncate LLC packet ACS should be disabled when > using normal DMA descriptors. > > Fixes: 47dd7a540b8a0 ("net: add support for STMicroelectronics Ethernet controllers.") > Cc: stable@vger.kernel.org > Signed-off-by: Remi Pommarel <repk@triplefau.lt>
Please don't CC: stable for networking fixes as per the netdev FAQ.
Applied and queued up for -stable, thank you.
| |