Messages in this thread | | | Date | Sun, 8 Mar 2020 22:26:49 +0100 | From | Pavel Machek <> | Subject | Re: [RFC PATCH 0/1] Add generic inverted led triggers |
| |
Hi!
> This patch adds generic inverted LED triggers. With this patch applied > any trigger can be used with inverted brightness levels by appending > "-inverted" to the name of a trigger.
Not a big fan (sorry).
We have already _way_ too many triggers, we don't want to have twice that much.
> This is can be useful for devices that do not have dedicated LEDs for e.g. > disk activity indication. With this patch applied the power led can be set > to default-state = on and trigger = disk-activity-inverted. Then the led > will be on by default, indicating the power state of the device but it > will turn off briefly whenever there is disk activity.
Better implementation might be to have a trigger attribute doing the inverting.
> I think dual-use of LEDs might come in handy for quite a few devices since > a lot of embedded boards and upcoming ARM based notebooks do only have one > or two LEDs.
Inverting really does not work with all the triggers; numlock-inverted will not get too many users. always-on-inverted... blink-inverted.... I guess it does make sense for disk activity (but be warned disk can be continuously active for quite a while).
What triggers do you think make sense inverted?
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |