lkml.org 
[lkml]   [2020]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCHv4 01/11] videobuf2: add cache management members
    From
    Date
    On 07/03/2020 10:46, Sergey Senozhatsky wrote:
    > On (20/03/06 14:57), Hans Verkuil wrote:
    > [..]
    >>> * @lock: pointer to a mutex that protects the &struct vb2_queue. The
    >>> * driver can set this to a mutex to let the v4l2 core serialize
    >>> * the queuing ioctls. If the driver wants to handle locking
    >>> @@ -564,6 +573,7 @@ struct vb2_queue {
    >>> unsigned requires_requests:1;
    >>> unsigned uses_qbuf:1;
    >>> unsigned uses_requests:1;
    >>> + unsigned allow_cache_hints:1;
    >
    > Shall I use "unsigned int" here instead of "unsigned"?

    The vb2_queue bitfields are the only places in that header were 'unsigned' is
    used. I think that that should be fixed in a separate patch. It's nice to have
    it consistent.

    Put that patch in the beginning of the series, that way I can pick it up in the
    next pull request.

    Regards,

    Hans

    >
    > -ss
    >

    \
     
     \ /
      Last update: 2020-03-07 11:10    [W:4.263 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site