Messages in this thread Patch in this message | | | Date | Sat, 7 Mar 2020 18:38:00 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCHv4 05/11] videobuf2: handle V4L2_FLAG_MEMORY_NON_CONSISTENT flag |
| |
On (20/03/07 16:51), Sergey Senozhatsky wrote: > On (20/03/06 16:30), Hans Verkuil wrote: > [..] > > > > > > /* capabilities for struct v4l2_requestbuffers and v4l2_create_buffers */ > > > @@ -2446,7 +2449,8 @@ struct v4l2_create_buffers { > > > __u32 memory; > > > struct v4l2_format format; > > > __u32 capabilities; > > > - __u32 reserved[7]; > > > + __u32 flags; > > > > The new flags argument needs to be documented in the command for struct v4l2_create_buffers. > >
Hans, what does "command for struct v4l2_create_buffers" mean?
BTW, I added v4l2_create_buffers::flags comment:
---
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 12b1bd220347..c6c1cccbb5c1 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -2441,6 +2441,8 @@ struct v4l2_dbg_chip_info { * @memory: enum v4l2_memory; buffer memory type * @format: frame format, for which buffers are requested * @capabilities: capabilities of this buffer type. + * @flags: additional buffer management attributes (ignored if queue + * does not have V4L2_BUF_CAP_SUPPORTS_CACHE_HINTS capability). * @reserved: future extensions */ struct v4l2_create_buffers {
| |