Messages in this thread | | | Date | Sat, 7 Mar 2020 03:10:21 +0900 | From | Masami Hiramatsu <> | Subject | Re: [BUGFIX PATCH] tools: Let O= makes handle a relative path with -C option |
| |
On Fri, 6 Mar 2020 08:26:43 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
> On 3/6/20 7:07 AM, Masami Hiramatsu wrote: > > Thanks Geert, > > > > So Randy, what you will get if you add "echo $(PWD)" instead of "cd $(PWD)" ? > > Is that still empty or shows the tools/bootconfig directory? > > > > Thanks, > > OK, in these lines: > + dummy := $(if $(shell cd $(PWD); test -d $(O) || echo $(O)),$(error O=$(O) does not exist),) > + ABSOLUTE_O := $(shell cd $(PWD); cd $(O) ; pwd) > > I changed both "cd $(PWD)" to "echo $(PWD)" and did > $ make O=BUILD -C tools/bootconfig/ > > and this is the build log: > > make: Entering directory '/home/rdunlap/lnx/next/linux-next-20200306/tools/bootconfig' > cc ../../lib/bootconfig.c main.c -Wall -g -I./include -o bootconfig > make: Leaving directory '/home/rdunlap/lnx/next/linux-next-20200306/tools/bootconfig' > > > Does that help?
Hmm, did you apply "[PATCH 1/2] bootconfig: Support O=<builddir> option" too?
Also, I found this is not enough for perf. perf does more tricky thing in its Makefile.
Thank you,
-- Masami Hiramatsu <mhiramat@kernel.org>
| |