lkml.org 
[lkml]   [2020]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mmc: cqhci: Update cqhci memory ioresource name
From
Date

On 3/4/2020 5:53 PM, Adrian Hunter wrote:
> On 4/03/20 2:00 pm, Veerabhadrarao Badiganti wrote:
>> Update cqhci memory ioresource name from cqhci_mem to cqhci since
>> suffix _mem is redundant.
> Which is OK only because sdhci-msm is the only caller of cqhci_pltfm_init(),
> right? So no one else could be using "cqhci_mem"? Some more explanation is
> needed here.

Right, only qcom cqhci solution is making use of it.

I did a grep in dt and find no other vendor is using it.

Sure. Will update commit text.

>> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
>> ---
>> Corresponding binding change:
>> https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/
>> ---
>> drivers/mmc/host/cqhci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
>> index e2ea2c4..e24b8ff 100644
>> --- a/drivers/mmc/host/cqhci.c
>> +++ b/drivers/mmc/host/cqhci.c
>> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>>
>> /* check and setup CMDQ interface */
>> cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>> - "cqhci_mem");
>> + "cqhci");
>> if (!cqhci_memres) {
>> dev_dbg(&pdev->dev, "CMDQ not supported\n");
>> return ERR_PTR(-EINVAL);
>>

\
 
 \ /
  Last update: 2020-03-04 14:13    [W:0.796 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site