Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch 06/24] x86/idtentry: Provide macros to define/declare IDT entry points | Date | Wed, 04 Mar 2020 13:46:20 +0100 |
| |
Alexandre Chartre <alexandre.chartre@oracle.com> writes: > On 2/25/20 11:16 PM, Thomas Gleixner wrote: >> +#else /* !__ASSEMBLY__ */ >> + >> +/* Defines for ASM code to construct the IDT entries */ >> +#define DECLARE_IDTENTRY(vector, func) \ >> + idtentry vector asm_##func func has_error_code=0 > > Should be DEFINE_IDENTRY(), no? Like the comment says: "Defines for > ..."
No. That's my confused brain. DECLARE_IDTENTRY is used for declarations in C code and for emitting the ASM stubs when included from entry*.S
I'll reword the comment and add some more documentation.
Thanks,
tglx
| |